Change in coreboot[master]: Consolidate reset API, add generic reset_prepare mechanism - coreboot-gerrit

26 May 2017


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/19789 )
Change subject: Consolidate reset API, add generic reset_prepare mechanism
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/19789/3/src/include/reset.h
File src/include/reset.h:
PS3, Line 12: /* SoC reset. Resets CPU and possibly some but not all IPs. */
...
I think this is a confusing one in that it's not even really a reset on x86
Yeah, it looks like it's actually not used anywhere. I'll take it out.
-- 
To view, visit https://review.coreboot.org/19789
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b89ce4a923102f0748922496e1dd9bce8a610f
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes