Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email )
Change subject: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC
......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79244/comment/0d4c9b5c_69e5f775 :
PS1, Line 7: update GPP_F17 to edge trigger
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/79244/comment/8c66c64c_cf480787 :
PS1, Line 9: AP
Application Processor?
Done
https://review.coreboot.org/c/coreboot/+/79244/comment/571cb7aa_0af84ab5 :
PS1, Line 9: it will cause
and it causes AP to keep sending
Done
https://review.coreboot.org/c/coreboot/+/79244/comment/c1f467f8_afc00c0e :
PS1, Line 9: GPP_F17
Unfortunately, I do not understand the commit message without looking at the comment in the diff. […]
Done
https://review.coreboot.org/c/coreboot/+/79244/comment/4ace17ff_75f6e597 :
PS1, Line 10: connect
connecting
Done
https://review.coreboot.org/c/coreboot/+/79244/comment/9d4c9df6_82286bd5 :
PS1, Line 14: TEST=Test on joxer with 6 units, 0 out of 60 times.
- What does “unit” refer to? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff
Gerrit-Change-Number: 79244
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 23 Nov 2023 00:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment