Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30383 )
Change subject: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 39: Code-Review+1
(3 comments)
+2 if this is tested
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig File src/soc/intel/broadwell/Kconfig:
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig@117 PS37, Line 117: default 0x2000 Tested?
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/bootblock/c... File src/soc/intel/broadwell/bootblock/cpu.c:
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/bootblock/c... PS37, Line 51: Was this redundant with `non-evic/cache_as_ram.S`?
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/romstage/ro... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/romstage/ro... PS37, Line 68: struct romstage_params rp = { : .bist = 0, /* checking done in the bootblock */ : .pei_data = NULL, : }; If I read this correctly, we are effectively passing 2x 0 to mainboard_romstage_entry(). Is this going to be cleaned up somewhere?
-
Nico Huber (Code Review)