Change in coreboot[master]: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig
All variants of hatch are using Comet Lake and so the selection can be done in Kconfig without requiring each variant to do the same.
Change-Id: Ief34296334ede5ba0f5f13381e92427ccc440707 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/35562/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index c4c9146..d4cf83d 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -20,6 +20,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE + select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP
if BOARD_GOOGLE_BASEBOARD_HATCH diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 01b6ead..fbc4c15 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -4,35 +4,29 @@ bool "-> Akemi" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_DRATINI bool "-> Dratini" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_KOHAKU bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_KINDRED bool "-> Kindred" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE select SOC_INTEL_COMMON_MMC_OVERRIDE
config BOARD_GOOGLE_HELIOS bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1:
I like it, how about adding BOARD_GOOGLE_BASEBOARD_HATCH ?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1:
Patch Set 1:
I like it, how about adding BOARD_GOOGLE_BASEBOARD_HATCH ?
Actually, that will still be required since BOARD_GOOGLE_${VARIANT} selects BOARD_GOOGLE_BASEBOARD_HATCH which then auto selects rest of the configs in Kconfig: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1: Code-Review+2
Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1: Code-Review+1
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35562 )
Change subject: mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig ......................................................................
mb/google/hatch: Move SOC_INTEL_COMETLAKE selection to Kconfig
All variants of hatch are using Comet Lake and so the selection can be done in Kconfig without requiring each variant to do the same.
Change-Id: Ief34296334ede5ba0f5f13381e92427ccc440707 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35562 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Andrew McRae amcrae@chromium.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Andrew McRae: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index c4c9146..d4cf83d 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -20,6 +20,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE + select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP
if BOARD_GOOGLE_BASEBOARD_HATCH diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 01b6ead..fbc4c15 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -4,35 +4,29 @@ bool "-> Akemi" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_DRATINI bool "-> Dratini" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_KOHAKU bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
config BOARD_GOOGLE_KINDRED bool "-> Kindred" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE select SOC_INTEL_COMMON_MMC_OVERRIDE
config BOARD_GOOGLE_HELIOS bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 - select SOC_INTEL_COMETLAKE
-
Andrew McRae (Code Review) -
Edward O'Callaghan (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)