Change in ...coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ......................................................................
Patch Set 51:
(2 comments)
https://review.coreboot.org/#/c/25634/51/src/soc/intel/common/block/cpu/Make... File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/#/c/25634/51/src/soc/intel/common/block/cpu/Make... PS51, Line 13: ramstage-$(CONFIG_SOC_INTEL_USES_MP_SERVICES_PPI) += mp_service_ppi.c This is FSP specific right?. So it should be implemented somewhere generalized in the fsp driver. Maybe drivers/intel/fsp2_0/ppi?
https://review.coreboot.org/#/c/25634/51/src/soc/intel/common/block/cpu/mp_s... File src/soc/intel/common/block/cpu/mp_service_ppi.c:
https://review.coreboot.org/#/c/25634/51/src/soc/intel/common/block/cpu/mp_s... PS51, Line 65: /* TODO: Fill EFI_PROCESSOR_INFORMATION *ProcessorInfoBuffer */ ? Can we implement it here or remove the TODO?
-
Philipp Deppenwiese (Code Review)