build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 1:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/8c737d51_534a8ad7 PS1, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/106a9c27_3332f1eb PS1, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/9a5444cc_b86629dd PS1, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/2b81c065_248ecf87 PS1, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/178aa946_a387b5cd PS1, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/d5c8728d_87c03144 PS1, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/f40b27bd_a26fd94d PS1, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/ca0477ab_ff35e928 PS1, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/e10b1773_7082d7d1 PS1, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/6fb4a493_fb2fe12d PS1, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/b067d885_766bc7d4 PS1, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/e95f84f7_76259d79 PS1, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/19b2da09_2c580801 PS1, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/f6eb42e2_1f917d0b PS1, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/40999bed_803b1c08 PS1, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/b902c9db_31854c3c PS1, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/1074f8ee_b4da59a1 PS1, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/470ff0bd_55935529 PS1, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/1259a10f_988cf38d PS1, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/969fb0ea_1137d952 PS1, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/e2616ae6_4c1dda0d PS1, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/e69fd2c5_437c33cb PS1, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/d2a8149b_f103217e PS1, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/4243c6a1_9e074578 PS1, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/c4c9555b_745d6b49 PS1, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118691): https://review.coreboot.org/c/coreboot/+/53902/comment/a59ba514_fd463891 PS1, Line 1140: if(!ret) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)