Attention is currently required from: Andy Hsu, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/85763?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB firmware v1.0 ......................................................................
Patch Set 4:
(4 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/85763/comment/be17e14e_4b9f71ef?usp=em... : PS1, Line 203: `tinysys-gpueb-RV33_A.mkpt_fw.img` to the SRAM of GPUEB.
move to the next line
Done
https://review.coreboot.org/c/blobs/+/85763/comment/7fdcd54d_2645d8b1?usp=em... : PS1, Line 203: . It will copy `tinysys-gpueb-RV33_A.mkpt_fw.img` to the SRAM of GPUEB.
`, parse it, and copy the resulting image to the SRAM of GPUEB`
Done
https://review.coreboot.org/c/blobs/+/85763/comment/b7cb12b2_5968a4a0?usp=em... : PS1, Line 207: reset to trigger GPUEB.
move to the next line
Done
File soc/mediatek/mt8196/tinysys-gpueb-RV33_A.mkpt_fw.img:
PS1:
Can we have a shorter file name please (such as `gpueb. […]
Done