Attention is currently required from: Tarun Tuli, Subrata Banik, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 18:
(6 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/82c6a953_41d29403 PS18, Line 183: // Index based on PCI_DEVFN() values coreboot doesn't really use `//` style comments: `/* Index based on PCI_DEVFN() values */`
https://review.coreboot.org/c/coreboot/+/63969/comment/afe4cedc_74ff9f52 PS18, Line 187: nit: extra space
https://review.coreboot.org/c/coreboot/+/63969/comment/3033c9be_aab8faab PS18, Line 247: if (!dev || !dev->enabled) nit: `if (!is_dev_enabled(dev))`
https://review.coreboot.org/c/coreboot/+/63969/comment/287569b7_d500e8f1 PS18, Line 255: int nit: `size_t`
https://review.coreboot.org/c/coreboot/+/63969/comment/527e7d11_0bee0d46 PS18, Line 269: uint8_t any particular reason this is 8 bits? why not `unsigned int` ?
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/a229dff3_7d5310b6 PS18, Line 77: lpi_get_constraints suggestion: rename this function now to `soc_lpi_get_constraints()`