Attention is currently required from: Tarun Tuli, Subrata Banik, Angel Pons.

View Change

6 comments:

• File src/soc/intel/alderlake/acpi.c:

  • Patch Set #18, Line 183: // Index based on PCI_DEVFN() values

    coreboot doesn't really use `//` style comments:
    `/* Index based on PCI_DEVFN() values */`

  • Patch Set #18, Line 187:

    nit: extra space

  • Patch Set #18, Line 247: if (!dev || !dev->enabled)

    nit:
    `if (!is_dev_enabled(dev))`

  • Patch Set #18, Line 255: int

    nit:
    `size_t`

  • Patch Set #18, Line 269: uint8_t

    any particular reason this is 8 bits? why not `unsigned int` ?

• File src/soc/intel/common/block/acpi/pep.c:

  • Patch Set #18, Line 77: lpi_get_constraints

    suggestion:
    rename this function now to
    `soc_lpi_get_constraints()`

To view, visit change 63969. To unsubscribe, or for help writing mail filters, visit settings.