Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39629 )
Change subject: mb/hp/z220: Fix VGA graphics init ......................................................................
mb/hp/z220: Fix VGA graphics init
The VGA port has the DDC on port B. Select the correct Kconfig and fix graphics init failing on VGA.
Tested on HP Z220, libgfxinit reports success and SeaBIOS is displayed on the connected VGA monitor.
Change-Id: Ie5ec1a2d4606a21e1dc4217ff6fefe5ee35ac543 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/39629/1
diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 8f28baf..82a9562 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -17,6 +17,7 @@ select SUPERIO_NUVOTON_NPCD378 select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT + select GFX_GMA_ANALOG_I2C_HDMI_B
config VBOOT select VBOOT_VBNV_CMOS
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39629 )
Change subject: mb/hp/z220: Fix VGA graphics init ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39629 )
Change subject: mb/hp/z220: Fix VGA graphics init ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39629 )
Change subject: mb/hp/z220: Fix VGA graphics init ......................................................................
mb/hp/z220: Fix VGA graphics init
The VGA port has the DDC on port B. Select the correct Kconfig and fix graphics init failing on VGA.
Tested on HP Z220, libgfxinit reports success and SeaBIOS is displayed on the connected VGA monitor.
Change-Id: Ie5ec1a2d4606a21e1dc4217ff6fefe5ee35ac543 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39629 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 8f28baf..82a9562 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -17,6 +17,7 @@ select SUPERIO_NUVOTON_NPCD378 select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT + select GFX_GMA_ANALOG_I2C_HDMI_B
config VBOOT select VBOOT_VBNV_CMOS
-
Nico Huber (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)