[XS] Change in coreboot[main]: security/vboot: Add option for enabling ADB over network via GBB flag

[Subrata Banik (Code Review)]

Attention is currently required from: Jon Murphy, Julius Werner, Kapil Porwal, Yu-Ping Wu.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87031?usp=email )

Change subject: security/vboot: Add option for enabling ADB over network via GBB flag
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> > I mean, we can start building coreboot from the firmware-android branch as well if you think this is important enough.
>
> yes, we are working on a specific fw branch to build fatcat.
> > Or you can put a line to set this after building in some script, or in an ebuild guarded by a USE flag or something. It does not belong here. (Besides, your patch sets it to `default n` anyway so on its own this patch does nothing?)
>
> that is correct but for CPFE builders to work, we need to make sure that we are checking that code as well (i.e., the code that edits the GBB bit 31) and this code just meant to do the same. I'm unable to find any other fatcat SoC/MB specific ebuild that would be applicable to set GBB bit 31 for ADB alone.

@Jon,

```That being said, I think there's still benefit to flushing it out and landing it on ToT. I'll follow up on my change.``` Are you planning to land your changelist upstream to avoid additional cherry-picking for the firmware branch? If so, then we can also land the coreboot and bboot changelists upstream so that we don't need any special cherry-picking in the firmware branch to enable ADB. Currently, many people overlook overriding the GBB and then claim that ADB isn't working.