Change in ...coreboot[master]: sb/intel: Fix pointer casts - coreboot-gerrit

5 Dec 2018


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29875 )
Change subject: sb/intel: Fix pointer casts
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c 
File src/southbridge/intel/i82801ix/lpc.c:
https://review.coreboot.org/#/c/29875/2/src/southbridge/intel/i82801ix/lpc.c... 
PS2, Line 556: acpigen_write_name_dword
is this really writing out a 64bit pointer when compiled for 64bit? Or is this just enough to get things through the compiler?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29875
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb3cacf25adfb4a242d38e4ea290fdc3929a684
Gerrit-Change-Number: 29875
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Wed, 05 Dec 2018 13:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment