Change in coreboot[master]: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool - coreboot-gerrit

12 Dec 2021


      Attention is currently required from: Paul Menzel, Patrick Rudolph.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60056 )
Change subject: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60056/comment/8d118b3b_485245ad 
PS1, Line 8:
...
Why is this better?
even if it was an "int",  "integrated_graphics" is already used as a "bool" at line #2128 ("integrated_graphics = false;").
Patchset:
PS1: 
Thx
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5286e691c312e8e44bbbd8e782fdfd4a13cb60f
Gerrit-Change-Number: 60056
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 12 Dec 2021 15:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment