Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85973?usp=email )
Change subject: mb/starlabs/*: Unset ADD_ITE_BINARY ......................................................................
mb/starlabs/*: Unset ADD_ITE_BINARY
This has always been set in downstream defconfig's; remove it here to avoid build issues with Jenkin's being unable to find a suitable EC binary.
Change-Id: I02a10211d7cec9a2c8a0837f77ca17acdcb06c22 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/85973 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/byte_adl/Kconfig M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starfighter/Kconfig M src/mainboard/starlabs/starlite_adl/Kconfig 4 files changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/Kconfig b/src/mainboard/starlabs/byte_adl/Kconfig index 1bd2fe0..77a4ea4 100644 --- a/src/mainboard/starlabs/byte_adl/Kconfig +++ b/src/mainboard/starlabs/byte_adl/Kconfig @@ -44,9 +44,6 @@ config EC_GPE_SCI default 0x6e
-config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_ITE_BIN_PATH string depends on EC_STARLABS_NEED_ITE_BIN diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 4a781e6..dfae2af 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -121,9 +121,6 @@ default 0x50 if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML default 0x6e
-config EC_STARLABS_ADD_ITE_BIN - default y if !BOARD_STARLABS_STARBOOK_RPL - config EC_STARLABS_BATTERY_MODEL default "AEC3987118-2S1P" if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML default "597077-3S" diff --git a/src/mainboard/starlabs/starfighter/Kconfig b/src/mainboard/starlabs/starfighter/Kconfig index 05d677e..e9c3b63 100644 --- a/src/mainboard/starlabs/starfighter/Kconfig +++ b/src/mainboard/starlabs/starfighter/Kconfig @@ -65,9 +65,6 @@ config EC_GPE_SCI default 0x6e
-config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_BATTERY_MODEL default "AEC617573-4S1P"
diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 1a0b15a..55a66be 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -58,9 +58,6 @@ config EC_GPE_SCI default 0x6e
-config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_BATTERY_MODEL default "AEC3756153-2S1P-N"