Attention is currently required from: Hung-Te Lin, Martin Roth, Julius Werner, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56130 )
Change subject: Revert "Makefile.inc: Drop the cbfs master header from non-X86"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56130/comment/958e8a88_e55fd8a8
PS1, Line 11: Breaks libpayload CBFS code when accessing
: non-primary CBFS.
No, by "primary CBFS" I meant the RW CBFS in the case where vboot is booting from RW. I guess "primary" was the wrong term... libpayload calls this "default CBFS media", the one that's passed in the boot_media_params coreboot table entry.
Ok thanks for clarifying. I see that there is FMAP support in libpayload. If the non-default CBFS media is on the COREBOOT fmap (the recovery path?) that could be used instead. I haven't look to deep into the code. Anyway lgtm and try to improve things later on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f47406e6126f19e1fd6bc9d33c8c9d0cb9450d
Gerrit-Change-Number: 56130
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 09 Jul 2021 00:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment