Attention is currently required from: Raul Rangel, Jeff Daly, Jakub Czapiga, Jonathan Zhang, Matt DeVillier, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov, Lance Zhao, Jason Glenesk, Johnny Lin, Tim Wawrzynczak, Christian Walter, Vanessa Eusebio, Fred Reitberger, Felix Held, Tim Chu.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69163 )
Change subject: cbmem_top: Change the return value to uintptr_t
......................................................................
Patch Set 9:
(6 comments)
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/69163/comment/d22eb485_e83e73c8
PS5, Line 663: (void *)cbmem_entry_start(to_be_updated) +
Misaligned code
Done
File src/include/imd.h:
https://review.coreboot.org/c/coreboot/+/69163/comment/833dac48_e9d01e06
PS7, Line 112: uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry);
It should not be changed as it returns `pointer`. `uintptr_t` is not appropriate here.
Done
File src/lib/imd.c:
https://review.coreboot.org/c/coreboot/+/69163/comment/cc54ff55_1e46ee25
PS7, Line 14: uintptr_t relative_pointer(void *base, ssize_t offset)
I think it should remain `void *`. This function has `pointer` in it's name.
Done
https://review.coreboot.org/c/coreboot/+/69163/comment/bff56412_7261dba4
PS7, Line 267: relative_pointer(imdr_root(imdr), e->start_offset);
`(uintptr_t)` will be needed here after reverting above.
Done
https://review.coreboot.org/c/coreboot/+/69163/comment/06191aa5_66e397ba
PS7, Line 568: uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry)
As in header file
Done
File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/69163/comment/90ef91bb_0f602aa7
PS7, Line 143: uintptr_t cbmem_add(u32 id, u64 size)
This also should remain `void *`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69163
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib757c0548f6f643747ba8d70228b3d6dfa5182cd
Gerrit-Change-Number: 69163
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 10:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment