[S] Change in coreboot[main]: soc/intel/pantherlake: Display Sign-of-Life during memory training

[Jérémy Compostella (Code Review)]

Attention is currently required from: Alok Agarwal, Anil Kumar K, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Vikrant L Jadeja.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )

Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................

Patch Set 21:

(1 comment)

File src/soc/intel/pantherlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/85454/comment/eaa0c36d_40e83ad7?usp... :
PS21, Line 387: 	m_cfg->VgaMessage = (efi_uintn_t)ux_locales_get_text(UX_LOCALE_MSG_MEMORY_TRAINING);
> > > Would https://review.coreboot.org/c/coreboot/+/86532 be acceptable ? […]

I have considered your point, and I agree with you that there is a slight leap of faith in the proposed refactoring of the code. The  Firmware Support Package (FSP) engineers are not going to guarantee that there won't be any changes in the upcoming generations. However, I would argue that:

1.  `VbtSize` and `LidStatus` have been in existence for some time (since the Alder Lake generation, and possibly even earlier, in System-on-Chips (SoCs) not supported by coreboot).
2.  `VbtPtr`, `VgaInitControl`, and `VgaMessage` have already persisted through several generations (Meteor Lake and Panther Lake, but also Lunar Lake, and as far as I know, Wildcat Lake).

I do not think it is particularly detrimental to provide a common function at this time and see how long we can continue to use it.