HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25509 )
Change subject: Add i945G based mainboard ......................................................................
Patch Set 36:
(2 comments)
Thank you
https://review.coreboot.org/c/coreboot/+/25509/35/src/mainboard/nec/945g-m4/... File src/mainboard/nec/945g-m4/cmos.layout:
https://review.coreboot.org/c/coreboot/+/25509/35/src/mainboard/nec/945g-m4/... PS35, Line 167: # : # Temperature (°C/°F) : #10 0 30/86 : #10 1 33/91 : #10 2 36/96 : #10 3 39/102 : #10 4 42/107 : #10 5 45/113 : #10 6 48/118 : #10 7 51/123 : #10 8 54/129 : #10 9 57/134 : #10 10 60/140 : #10 11 63/145 : #10 12 66/150 : #10 13 69/156 : #10 14 72/161 : #10 15 75/167
clean this up?
Done
https://review.coreboot.org/c/coreboot/+/25509/35/src/northbridge/intel/i945... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/25509/35/src/northbridge/intel/i945... PS35, Line 896: // if (CONFIG(NORTHBRIDGE_INTEL_SUBTYPE_I945GM))
unrelated?
Done
-
HAOUAS Elyes (Code Review)