Change in ...coreboot[master]: Revert "mb/google/arcada: Add settings for noise mitgation"
Hello Nathan Chen, build bot (Jenkins), Lijian Zhao, Patrick Georgi, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32472
to review the following change.
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Revert "mb/google/arcada: Add settings for noise mitgation"
This reverts commit 77fb3632a4a3d3004b3aa4950967be9164d9711d.
Reason for revert: This change inadvertently added a submodule.
Change-Id: I6cc2a3cd9d88986a2599a5ff2e5a066b1396a8c0 Signed-off-by: Duncan Laurie dlaurie@google.com --- D coreboot M src/mainboard/google/sarien/variants/arcada/devicetree.cb 2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32472/1
diff --git a/coreboot b/coreboot deleted file mode 160000 index 1db39a4..0000000 --- a/coreboot +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 1db39a44661f57c2ffe0d795e21c0a4d5dddb494 diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 426bdae..57c4e65 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -37,10 +37,10 @@ register "tdp_pl2_override" = "51" register "Device4Enable" = "1" register "AcousticNoiseMitigation" = "1" - register "SlowSlewRateForIa" = "2" - register "SlowSlewRateForGt" = "2" + register "SlowSlewRateForIa" = "0" + register "SlowSlewRateForGt" = "0" register "SlowSlewRateForSa" = "0" - register "SlowSlewRateForFivr" = "2" + register "SlowSlewRateForFivr" = "0" # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 1:
Nathan please resubmit with just the mainboard change.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 1: Code-Review+2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 1: Code-Review+2
Thank You for immediate response.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 1:
Submitting to remove this asap so it doesn't cause more issues for people.
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Revert "mb/google/arcada: Add settings for noise mitgation"
This reverts commit 77fb3632a4a3d3004b3aa4950967be9164d9711d.
Reason for revert: This change inadvertently added a submodule.
Change-Id: I6cc2a3cd9d88986a2599a5ff2e5a066b1396a8c0 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32472 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- D coreboot M src/mainboard/google/sarien/variants/arcada/devicetree.cb 2 files changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/coreboot b/coreboot deleted file mode 160000 index 1db39a4..0000000 --- a/coreboot +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 1db39a44661f57c2ffe0d795e21c0a4d5dddb494 diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 426bdae..57c4e65 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -37,10 +37,10 @@ register "tdp_pl2_override" = "51" register "Device4Enable" = "1" register "AcousticNoiseMitigation" = "1" - register "SlowSlewRateForIa" = "2" - register "SlowSlewRateForGt" = "2" + register "SlowSlewRateForIa" = "0" + register "SlowSlewRateForGt" = "0" register "SlowSlewRateForSa" = "0" - register "SlowSlewRateForFivr" = "2" + register "SlowSlewRateForFivr" = "0" # Enable eDP device register "DdiPortEdp" = "1" # Enable HPD for DDI ports B/C
Nathan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32472 )
Change subject: Revert "mb/google/arcada: Add settings for noise mitgation" ......................................................................
Patch Set 2:
Patch Set 1:
Nathan please resubmit with just the mainboard change.
Hi Duncan, resubmit at 32521, please help to review.
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Michał Żygowski (Code Review)
-
Nathan Chen (Code Review)