Attention is currently required from: Michał Kopeć, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 )
Change subject: intelblocks/vtd: Add VT-d block with DMA protection API
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/vtd/vtd.c:
https://review.coreboot.org/c/coreboot/+/68449/comment/6b2db699_a36435e5
PS7, Line 158: if (vtd_read32(vtd_base, PMEN_REG) & PMEN_PRS) {
Looks like these `if`s don't need to be nested
This is a recheck if the protection has been really disabled after clearing PMEN_EPM. What do you mean by "don't need to be nested"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7edf982457c1139624e5cd383788eda41d6a948
Gerrit-Change-Number: 68449
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 15:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment