[XS] Change in coreboot[main]: tree: Use boolean for dptf_enable - coreboot-gerrit

29 Sep 2024


      Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Eric Lai, Erik van den Bogaert, Frans Hendriks, Jakub Czapiga, Jayvik Desai, Jonathon Hall, Kapil Porwal, Lean Sheng Tan, Maxim, Michał Żygowski, Nick Vaccaro, Nico Huber, Piotr Król, Pranava Y N, Rishika Raj, Subrata Banik, Tarun, Werner Zeh.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84161?usp=email )
Change subject: tree: Use boolean for dptf_enable
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
...
...
For my understanding, the natural language for "dptf_enable" would be "yes/no". […]
Ok, now I've just changed `int dptf_enable;` with `bool dptf_enable;`
Is it ok for you?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84161?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6e578199e7e4ca3a014eecb1eb7a4d9d24893b8
Gerrit-Change-Number: 84161
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Erik van den Bogaert ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Maxim max.senia.poliak@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Rishika Raj rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Rishika Raj rishikaraj@google.com
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Jakub Czapiga czapiga@google.com
Gerrit-Attention: Frans Hendriks fhendriks@eltan.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Attention: Erik van den Bogaert ebogaert@eltan.com
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maxim max.senia.poliak@gmail.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Comment-Date: Sun, 29 Sep 2024 14:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai ericllai@google.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr