Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41457 )
Change subject: sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS ......................................................................
sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS
Only two mainboard groups use this southbridge:
emulation/qemu-i440fx: Nothing creates or consumes this ACPI path. asus/p2b: It only fills the (mostly static) PIIX4E PM/SMBus I/O resources, which are being declared in DSDT.
It is not doing anything useful and causes ACPI errors in Linux kernel[1][2], so it has to stop.
[1] https://review.coreboot.org/c/coreboot/+/38601 [2] https://review.coreboot.org/c/coreboot/+/38304
Change-Id: I770047610e02c08191613b57c989b3bc1d464684 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/isa.c 1 file changed, 1 insertion(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41457/1
diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c index efbfb22..83e2789 100644 --- a/src/southbridge/intel/i82371eb/isa.c +++ b/src/southbridge/intel/i82371eb/isa.c @@ -104,21 +104,13 @@ #endif }
-#if CONFIG(HAVE_ACPI_TABLES) -static void southbridge_acpi_fill_ssdt_generator(const struct device *device) -{ - acpigen_write_mainboard_resources("\_SB.PCI0.MBRS", "_CRS"); - generate_cpu_entries(device); -} -#endif - static const struct device_operations isa_ops = { .read_resources = sb_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, #if CONFIG(HAVE_ACPI_TABLES) .write_acpi_tables = acpi_write_hpet, - .acpi_fill_ssdt = southbridge_acpi_fill_ssdt_generator, + .acpi_fill_ssdt = generate_cpu_entries, #endif .init = isa_init, .scan_bus = scan_static_bus,
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41457 )
Change subject: sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41457 )
Change subject: sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41457 )
Change subject: sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS ......................................................................
sb/intel/i82371eb: Don't fill _SB.PCI0.MBRS
Only two mainboard groups use this southbridge:
emulation/qemu-i440fx: Nothing creates or consumes this ACPI path. asus/p2b: It only fills the (mostly static) PIIX4E PM/SMBus I/O resources, which are being declared in DSDT.
It is not doing anything useful and causes ACPI errors in Linux kernel[1][2], so it has to stop.
[1] https://review.coreboot.org/c/coreboot/+/38601 [2] https://review.coreboot.org/c/coreboot/+/38304
Change-Id: I770047610e02c08191613b57c989b3bc1d464684 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41457 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/southbridge/intel/i82371eb/isa.c 1 file changed, 1 insertion(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c index ae35d90..237ed36 100644 --- a/src/southbridge/intel/i82371eb/isa.c +++ b/src/southbridge/intel/i82371eb/isa.c @@ -102,21 +102,13 @@ #endif }
-#if CONFIG(HAVE_ACPI_TABLES) -static void southbridge_acpi_fill_ssdt_generator(const struct device *device) -{ - acpigen_write_mainboard_resources("\_SB.PCI0.MBRS", "_CRS"); - generate_cpu_entries(device); -} -#endif - static const struct device_operations isa_ops = { .read_resources = sb_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, #if CONFIG(HAVE_ACPI_TABLES) .write_acpi_tables = acpi_write_hpet, - .acpi_fill_ssdt = southbridge_acpi_fill_ssdt_generator, + .acpi_fill_ssdt = generate_cpu_entries, #endif .init = isa_init, .scan_bus = scan_static_bus,
-
Angel Pons (Code Review) -
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)