Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Aamir Bohra has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
Patch Set 16:
(2 comments)
Patchset:
PS2:
Apologies for my late response. […]
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/86599/comment/14a1cfc6_0a0eea66?usp... :
PS15, Line 26: EC_GOOGLE_CHROMEEC_SKUID
looks like you have remove this Kconfig in previous CL https://review.coreboot. […]
yes, as google_chromeec_get_board_sku was no longer controlled by CONFIG_EC_GOOGLE_CHROMEEC_SKUID
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 16
Gerrit-Owner: Aamir Bohra
aamirbohra@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 03 Apr 2025 11:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Aamir Bohra
aamirbohra@google.com