[M] Change in coreboot[master]: drivers/i2c/rv3028c7: Add ACPI generation callbacks - coreboot-gerrit

14 Nov 2022


      Attention is currently required from: Werner Zeh, Jan Samek.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/69543/comment/679d8c74_4ba5d963 
PS1, Line 197: bus_speed = I2C_SPEED_STANDARD;
Hi Jan, if datasheet says 'I2C-bus interface: 400 kHz', shouldn't 'I2C_SPEED_FAST' here?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Samek jan.samek@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-CC: Johannes Hahn johannes-hahn@siemens.com
Gerrit-CC: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-CC: Uwe Poeche uwe.poeche@siemens.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Jan Samek jan.samek@siemens.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 14:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment