Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28104 )
Change subject: lib/fit_payload: Add coreboot tables support for FDT.
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c@140
PS8, Line 140: cbmem_get_imd
I'm confused... how does this build? cbmem_get_imd() is a static inline in another .c file. […]
It's not build tested. I'll add a config in a separate commit.
--
To view, visit
https://review.coreboot.org/28104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977
Gerrit-Change-Number: 28104
Gerrit-PatchSet: 8
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 17 Aug 2018 10:13:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No