Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43121 )
Change subject: haswell boards: Drop unused romstage.c includes ......................................................................
haswell boards: Drop unused romstage.c includes
Several of these includes are no longer necessary. Get rid of them.
Change-Id: Ia7e9dadf87114ca9ea4761b89909ea035cdfc38a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/romstage.c M src/mainboard/asrock/h81m-hds/romstage.c M src/mainboard/google/beltino/romstage.c M src/mainboard/google/slippy/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/mainboard/lenovo/t440p/romstage.c M src/mainboard/supermicro/x10slm-f/romstage.c 7 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43121/1
diff --git a/src/mainboard/asrock/b85m_pro4/romstage.c b/src/mainboard/asrock/b85m_pro4/romstage.c index c9eb981..fe24eda 100644 --- a/src/mainboard/asrock/b85m_pro4/romstage.c +++ b/src/mainboard/asrock/b85m_pro4/romstage.c @@ -1,11 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> -#include <device/pnp_ops.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/pei_data.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/asrock/h81m-hds/romstage.c b/src/mainboard/asrock/h81m-hds/romstage.c index f29bd70..7465e74 100644 --- a/src/mainboard/asrock/h81m-hds/romstage.c +++ b/src/mainboard/asrock/h81m-hds/romstage.c @@ -1,11 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> -#include <device/pnp_ops.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/pei_data.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/google/beltino/romstage.c b/src/mainboard/google/beltino/romstage.c index 525edf4..54295a4 100644 --- a/src/mainboard/google/beltino/romstage.c +++ b/src/mainboard/google/beltino/romstage.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/lynxpoint/lp_gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/google/slippy/romstage.c b/src/mainboard/google/slippy/romstage.c index 6145432..bed81c0 100644 --- a/src/mainboard/google/slippy/romstage.c +++ b/src/mainboard/google/slippy/romstage.c @@ -1,10 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <southbridge/intel/lynxpoint/lp_gpio.h> #include "variant.h"
void mainboard_config_rcba(void) diff --git a/src/mainboard/intel/baskingridge/romstage.c b/src/mainboard/intel/baskingridge/romstage.c index 6b2dfa7..6b7026a 100644 --- a/src/mainboard/intel/baskingridge/romstage.c +++ b/src/mainboard/intel/baskingridge/romstage.c @@ -1,12 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <stddef.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <southbridge/intel/common/gpio.h>
void mainboard_config_rcba(void) { diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index 7b09df4..fa38389 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -1,10 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/pei_data.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> #include <option.h> #include <ec/lenovo/pmh7/pmh7.h> diff --git a/src/mainboard/supermicro/x10slm-f/romstage.c b/src/mainboard/supermicro/x10slm-f/romstage.c index 64d6981..727f040 100644 --- a/src/mainboard/supermicro/x10slm-f/romstage.c +++ b/src/mainboard/supermicro/x10slm-f/romstage.c @@ -1,11 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/pei_data.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <stdint.h>
void mainboard_config_rcba(void) {
Hello build bot (Jenkins), Tristan Corrick, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43121
to look at the new patch set (#2).
Change subject: haswell boards: Drop unused romstage.c includes ......................................................................
haswell boards: Drop unused romstage.c includes
Several of these includes are no longer necessary. Get rid of them. Since "raminit.h" already includes "pei_data.h", we can omit including the latter for brevity's sake.
Change-Id: Ia7e9dadf87114ca9ea4761b89909ea035cdfc38a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/romstage.c M src/mainboard/asrock/h81m-hds/romstage.c M src/mainboard/google/beltino/romstage.c M src/mainboard/google/slippy/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/mainboard/lenovo/t440p/romstage.c M src/mainboard/supermicro/x10slm-f/romstage.c 7 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43121/2
Hello build bot (Jenkins), Tristan Corrick, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43121
to look at the new patch set (#3).
Change subject: haswell boards: Drop unused romstage.c includes ......................................................................
haswell boards: Drop unused romstage.c includes
Several of these includes are no longer necessary. Get rid of them. Since "raminit.h" already includes "pei_data.h", we can omit including the latter for brevity's sake.
Change-Id: Ia7e9dadf87114ca9ea4761b89909ea035cdfc38a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/romstage.c M src/mainboard/asrock/h81m-hds/romstage.c M src/mainboard/google/beltino/romstage.c M src/mainboard/google/slippy/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/mainboard/lenovo/t440p/romstage.c M src/mainboard/supermicro/x10slm-f/romstage.c 7 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43121/3
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43121 )
Change subject: haswell boards: Drop unused romstage.c includes ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43121 )
Change subject: haswell boards: Drop unused romstage.c includes ......................................................................
haswell boards: Drop unused romstage.c includes
Several of these includes are no longer necessary. Get rid of them. Since "raminit.h" already includes "pei_data.h", we can omit including the latter for brevity's sake.
Change-Id: Ia7e9dadf87114ca9ea4761b89909ea035cdfc38a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43121 Reviewed-by: Tristan Corrick tristan@corrick.kiwi Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/romstage.c M src/mainboard/asrock/h81m-hds/romstage.c M src/mainboard/google/beltino/romstage.c M src/mainboard/google/slippy/romstage.c M src/mainboard/intel/baskingridge/romstage.c M src/mainboard/lenovo/t440p/romstage.c M src/mainboard/supermicro/x10slm-f/romstage.c 7 files changed, 0 insertions(+), 26 deletions(-)
Approvals: build bot (Jenkins): Verified Tristan Corrick: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/romstage.c b/src/mainboard/asrock/b85m_pro4/romstage.c index c9c12df..a2b8607 100644 --- a/src/mainboard/asrock/b85m_pro4/romstage.c +++ b/src/mainboard/asrock/b85m_pro4/romstage.c @@ -1,12 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> -#include <device/pnp_ops.h> #include <northbridge/intel/haswell/haswell.h> -#include <northbridge/intel/haswell/pei_data.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/asrock/h81m-hds/romstage.c b/src/mainboard/asrock/h81m-hds/romstage.c index 6847ff2..761e9d8 100644 --- a/src/mainboard/asrock/h81m-hds/romstage.c +++ b/src/mainboard/asrock/h81m-hds/romstage.c @@ -1,12 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> -#include <device/pnp_ops.h> #include <northbridge/intel/haswell/haswell.h> -#include <northbridge/intel/haswell/pei_data.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/google/beltino/romstage.c b/src/mainboard/google/beltino/romstage.c index 525edf4..54295a4 100644 --- a/src/mainboard/google/beltino/romstage.c +++ b/src/mainboard/google/beltino/romstage.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/lynxpoint/lp_gpio.h> #include <southbridge/intel/lynxpoint/pch.h>
void mainboard_config_rcba(void) diff --git a/src/mainboard/google/slippy/romstage.c b/src/mainboard/google/slippy/romstage.c index 6145432..bed81c0 100644 --- a/src/mainboard/google/slippy/romstage.c +++ b/src/mainboard/google/slippy/romstage.c @@ -1,10 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <southbridge/intel/lynxpoint/lp_gpio.h> #include "variant.h"
void mainboard_config_rcba(void) diff --git a/src/mainboard/intel/baskingridge/romstage.c b/src/mainboard/intel/baskingridge/romstage.c index 6b2dfa7..6b7026a 100644 --- a/src/mainboard/intel/baskingridge/romstage.c +++ b/src/mainboard/intel/baskingridge/romstage.c @@ -1,12 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> -#include <stddef.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <southbridge/intel/common/gpio.h>
void mainboard_config_rcba(void) { diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index 23a12aa..5a5f2de 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -1,11 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> -#include <northbridge/intel/haswell/pei_data.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> #include <option.h> #include <ec/lenovo/pmh7/pmh7.h> diff --git a/src/mainboard/supermicro/x10slm-f/romstage.c b/src/mainboard/supermicro/x10slm-f/romstage.c index 09e8df1..8c38380 100644 --- a/src/mainboard/supermicro/x10slm-f/romstage.c +++ b/src/mainboard/supermicro/x10slm-f/romstage.c @@ -1,12 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/intel/haswell/haswell.h> #include <northbridge/intel/haswell/haswell.h> -#include <northbridge/intel/haswell/pei_data.h> #include <northbridge/intel/haswell/raminit.h> -#include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <stdint.h>
void mainboard_config_rcba(void) {