[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig - coreboot-gerrit

31 Jan 2025


      Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held.
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email )
Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig
......................................................................
Patch Set 4:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/86131/comment/9a901afc_7f37e88a?usp... :
PS4, Line 1015: 	default y
...
I don't think it is
According to Arthur Heymans, it should be on for non-x86. Not sure if it would have any negative impact, but I didn't see any problematic code in the tree other than Intel's Braswell/ApolloLake and blocks like crashlog (which obviously is x86)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5
Gerrit-Change-Number: 86131
Gerrit-PatchSet: 4
Gerrit-Owner: Alicja Michalska ahplka19@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 31 Jan 2025 11:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de