Change in coreboot[master]: amd/common/block/acpi/pm_state: fix comparison in get_index_bit - coreboot-gerrit

4 Feb 2021


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50243 )
Change subject: amd/common/block/acpi/pm_state: fix comparison in get_index_bit
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50243/comment/2c5958e0_6dd27f3d 
PS3, Line 10: continued, since 32 is a valid value here.
...
And the case of limit > 32 should really be a BUG() or assert() since uint32t for the parameter 'val […]
good point. since you wrote that you're going to look into this, i won't push a patch for that
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ca341841bad62abcb4ea26a350c539813a29de7
Gerrit-Change-Number: 50243
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 16:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment