Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kane Chen, Kapil Porwal, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79654?usp=email )
Change subject: soc/intel/mtl: Enable SOC_INTEL_COMMON_BLOCK_SMM_TCO_ENABLE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
lets wait for sometime to land this CL as I'm not clear if any intruder is trying to flip the WPD status and if we follow the trap and clear the SMI which is not correct IMO.
we can land this cl based on the debug data
Disabling Write Protection (WP) without first clearing the System Management Interrupt (SMI) can lead to issues. When setting WP from 0 to 1, the SMI bit is also set to 1. If we then attempt to disable WP (change the WPD bit) while the SMI bit remains at 1, we are effectively trying to clear the SMI bit using software. However, the SMI bit (1C) can only be cleared by hardware through a De-assert Synchronous SMI message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1f096f8eda4adcf1627e44afa517b02adddad76
Gerrit-Change-Number: 79654
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 19 Jan 2024 10:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment