Attention is currently required from: Raul Rangel, Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56577 )
Change subject: lib/cbfs: Enable cbfs_cache for x86 ......................................................................
Patch Set 5:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/56577/comment/d35a7689_078a0f0c PS5, Line 322: || !cbfs_cache.size
_cbfs_cache needs to be optional because it's not defined in the memlayout on x86 platforms. If I change it from an optional region I get the following:
Right, I'm saying make it required and then also put the section in all x86 boards at the same time. If that's too much at once, you can do it piecemeal... e.g. start with
#define CBFS_CACHE_AVAILABLE (ENV_STAGE_HAS_DATA_SECTION && !CONFIG(SOC_AMD_COMMON))
and then add the AMD support in a later patch or something. But I think the end goal should be that every platform where CBFS_CACHE_AVAILABLE is true actually has a CBFS cache, and that the linker verifies that so no mistakes can creep in.
-
Julius Werner (Code Review)