Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52913 )
Change subject: soc/amd/{picasso,common/blocks/pci}: Move populate_pirq_data
......................................................................
Patch Set 8:
(2 comments)
File src/soc/amd/common/fsp/pci/pirq.c:
https://review.coreboot.org/c/coreboot/+/52913/comment/07f70270_eb74f3dd
PS3, Line 19:
might be a good idea to check if entries is != 0 before calling calloc
Done
https://review.coreboot.org/c/coreboot/+/52913/comment/34f91f3f_51b67d4c
PS3, Line 23: return;
add some BIOS_ERR printk here? for a valid routing table calloc isn't supposed to return NULL
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I297fc3ca7227fb4794ac70bd046ce2f93da8b869
Gerrit-Change-Number: 52913
Gerrit-PatchSet: 8
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 May 2021 01:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment