Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 )
Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ......................................................................
Patch Set 1:
(3 comments)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/59245/comment/6beaf1ff_61d22643 PS1, Line 174: };;
Statements terminations use 1 semicolon
Please fix.
https://review.coreboot.org/c/coreboot/+/59245/comment/b7d3dd1b_7c25970e PS1, Line 606: printk(BIOS_WARNING, "%s: ID = %#x \n", __func__,
unnecessary whitespace before a quoted newline
Please fix.
File src/soc/mediatek/mt8186/pmic_wrap.c:
https://review.coreboot.org/c/coreboot/+/59245/comment/6bea412f_6466f7c5 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f);
please, no space before tabs
Please fix.
-
Yu-Ping Wu (Code Review)