Attention is currently required from: Reka Norman.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )
Change subject: util/ifdtool: Add new cmdline to enable GPR0 protection ......................................................................
Patch Set 3:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/80235/comment/19fe01cb_01fb7504 : PS3, Line 47: CSE_REGION_DATA_PARTITION_OFFSET
This applies to BPDT v1.7 (TGL onwards) only, referring to util/cbfstool/bpdt_formats/{bpdt_1_6.c,bpdt_1_7.c}. Do we want to support v1.6 too? Or just say it's unsupported on platforms older than TGL for now?
I think this is part of the generic CSE layout outside BPDT. I could see offset 24 (0x18) always holds the CSE data region offset
24 | Data partition offset | Offset of data partition from start of CSE region
you are right, this is layout specific. let me fix it
-
Subrata Banik (Code Review)