Change in coreboot[master]: [TESTME] nb/intel/ironlake: Fix some quickpath init magic - coreboot-gerrit

19 Dec 2021


      Attention is currently required from: Paul Menzel, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60216 )
Change subject: [TESTME] nb/intel/ironlake: Fix some quickpath init magic
......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/60216/comment/3591b58b_467561f0 
PS1, Line 3396: 	rdmsr(0x1ac);	// !!!!
...
What happens on the Apple iMac, if this stays?
Nothing. It's just that this MSR is now read in quickpath.c (I added a define for it) and its value is used in there, so this is superfluous.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60216
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd0139aa588dc8d948c03132b5c86866d90f3231
Gerrit-Change-Number: 60216
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment