Attention is currently required from: Angel Pons, Arthur Heymans, Martin L Roth.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email )
Change subject: treewide: Add generation of CFR Tables
......................................................................
Patch Set 7:
(2 comments)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/82494/comment/fce927eb_008f8fec?usp... :
PS7, Line 568: __weak
What does Atlas need to do? If possible, I'd suggest having something like `void __weak mainboard_up […]
Then you have another weak function. But I see that having an extra specific `mainboard_*` weak function might be beneficial.
https://review.coreboot.org/c/coreboot/+/82494/comment/5ef55a40_079e00bc?usp... :
PS7, Line 575: size_t size = cbfs_load("fallback/sot", sot_buf, MAX_SOT_SIZE);
Is there a way to get the uncompressed size of a CBFS file at runtime? If so, it would be nice to us […]
I guess I could just use `cbfs_cbmem_alloc()`. Will try that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133
Gerrit-Change-Number: 82494
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 01 Jul 2024 13:26:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz