Attention is currently required from: Kane Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 )
Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 3:
(6 comments)
File src/mainboard/google/zork/variants/shuboz/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/4a3ae7e2_9e1b56ac PS3, Line 84: ARRAY_SIZE(machine_dev_path)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/ac80f4fe_2760fa42 PS3, Line 84: ARRAY_SIZE(machine_dev_path)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/d432410a_ab2b8703 PS3, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/091eacee_84f37862 PS3, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/3f708abe_43ce019a PS3, Line 99: machine_dev_config->hid); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/be9f5761_509c976f PS3, Line 99: machine_dev_config->hid); please, no spaces at the start of a line