Attention is currently required from: Sean Rhodes, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62990 )
Change subject: drivers/smmstore: Enable 4KiB blocks in SMMSTORE ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Okay, so easy solution, make it a Kconfig option?
A user visibly one seems like a bad idea. You don't want things exposed that can be wrongly configured. Even hidden ones selected by specific SPI drivers sounds messy and maybe even impossible as some vendors have chips that support 4K and 64K erase and there is no possibility to distinguish properly at a Kconfig level. I think the proper fix is to fix the payload, not to work around it in coreboot.
Can you not just top align the COREBOOT region in fmap and BIOS region in IFD to work around this?
-
Arthur Heymans (Code Review)