Change in coreboot[master]: mainboard/hatch: Fix puff USB ACPI names and types

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38473 )

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

mainboard/hatch: Fix puff USB ACPI names and types

Fix devicetree to advertise the correct USB names and types
in the generated ASL.

BUG=b:146437991
BRANCH=none
TEST=none

Change-Id: I133b4db444f9a5f0a36d8e976ae490f24cf307d8
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/variants/puff/overridetree.cb
1 file changed, 14 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38473/1

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index 2e40ba9..1d2fc47 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -181,8 +181,8 @@
    		chip drivers/usb/acpi
    			device usb 0.0 on
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 2""
-						register "type" = "UPC_TYPE_A"
+						register "desc" = ""USB2 Type-C Rear""
+						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
@@ -191,22 +191,22 @@
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 3""
+						register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 1""
+						register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 4""
+						register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 0""
+						register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.5 on end
    				end
@@ -214,32 +214,32 @@
    					device usb 2.6 off end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 2""
-						register "type" = "UPC_TYPE_USB3_A"
+						register "desc" = ""USB3 Type-C Rear""
+						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 3""
+						register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 1""
+						register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-C Port""
-						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "desc" = ""USB3 Type-A Front Left""
+						register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 0""
+						register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 4""
+						register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.5 on end
    				end

[Edward O'Callaghan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38473

to look at the new patch set (#2).

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

mainboard/hatch: Fix puff USB ACPI names and types

Fix devicetree to advertise the correct USB names and types
in the generated ASL.

BUG=b:146437991
BRANCH=none
TEST=none

Change-Id: I133b4db444f9a5f0a36d8e976ae490f24cf307d8
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/variants/puff/overridetree.cb
1 file changed, 12 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38473/2

[Edward O'Callaghan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38473

to look at the new patch set (#3).

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

mainboard/hatch: Fix puff USB ACPI names and types

Fix devicetree to advertise the correct USB names and types
in the generated ASL.

BUG=b:146437991
BRANCH=none
TEST=booted and inspected the reported generated ASL.

Change-Id: I133b4db444f9a5f0a36d8e976ae490f24cf307d8
Signed-off-by: Edward O'Callaghan 
---
M src/mainboard/google/hatch/variants/puff/overridetree.cb
1 file changed, 12 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38473/3

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38473 )

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

Patch Set 3: Code-Review+2

[Kangheui Won (Code Review)]

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38473 )

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

Patch Set 3: Code-Review+1

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38473 )

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

mainboard/hatch: Fix puff USB ACPI names and types

Fix devicetree to advertise the correct USB names and types
in the generated ASL.

BUG=b:146437991
BRANCH=none
TEST=booted and inspected the reported generated ASL.

Change-Id: I133b4db444f9a5f0a36d8e976ae490f24cf307d8
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38473
Tested-by: build bot (Jenkins) 
Reviewed-by: Daniel Kurtz 
Reviewed-by: Kangheui Won 
---
M src/mainboard/google/hatch/variants/puff/overridetree.cb
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Daniel Kurtz: Looks good to me, approved
  Kangheui Won: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index 2e40ba9..e7fe907 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -181,32 +181,32 @@
    		chip drivers/usb/acpi
    			device usb 0.0 on
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 2""
+						register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-C Port""
+						register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 3""
+						register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 1""
+						register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 4""
+						register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 0""
+						register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
    					device usb 2.5 on end
    				end
@@ -214,32 +214,32 @@
    					device usb 2.6 off end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 2""
+						register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 3""
+						register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 1""
+						register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-C Port""
+						register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 0""
+						register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
-						register "desc" = ""Type-A Port 4""
+						register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
    					device usb 3.5 on end
    				end

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38473 )

Change subject: mainboard/hatch: Fix puff USB ACPI names and types
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/204
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/203
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/202

Please note: This test is under development and might not be accurate at all!