Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57785 )
Change subject: soc/intel/block: Add small crashlog helper library
......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/common/block/crashlog/crashlog_lib.c:
https://review.coreboot.org/c/coreboot/+/57785/comment/baa33f34_00eaaa2f
PS3, Line 4: #include "crashlog_lib.h"
nit - local "" includes should follow system <> includes ordering-wise, with blank line between the the system includes and the local include sections.
https://review.coreboot.org/c/coreboot/+/57785/comment/247d9381_0504b42c
PS3, Line 10: size_t
Why is this a size_t?
https://review.coreboot.org/c/coreboot/+/57785/comment/2b52f44a_e973e266
PS3, Line 30: next_pos
Is this needed? Why not set pos directly?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c48d2e35d621b1cc3bb7931c666ae15a0d2fe7e
Gerrit-Change-Number: 57785
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 28 Sep 2021 02:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment