Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian.

View Change

3 comments:

• File src/soc/intel/common/block/crashlog/crashlog_lib.c:

  • Patch Set #3, Line 4: #include "crashlog_lib.h"

    nit - local "" includes should follow system <> includes ordering-wise, with blank line between the the system includes and the local include sections.

  • Patch Set #3, Line 10: size_t

    Why is this a size_t?

  • Patch Set #3, Line 30: next_pos

    Is this needed? Why not set pos directly?

To view, visit change 57785. To unsubscribe, or for help writing mail filters, visit settings.