Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44588/9/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/44588/9/src/mainboard/google/dedede...
PS9, Line 11: PAD_CFG_GPO(GPP_A10, 0, PLTRST),
power_enable need to pull up.
Done
https://review.coreboot.org/c/coreboot/+/44588/9/src/mainboard/google/dedede...
PS9, Line 45: PAD_CFG_GPO(GPP_H17, 0, PLTRST),
RESET need to pull up.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d5d21ce5267f147b332a4c9b01a29b3b8ccfb8
Gerrit-Change-Number: 44588
Gerrit-PatchSet: 10
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Comment-Date: Sat, 31 Oct 2020 06:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-MessageType: comment