Change in coreboot[master]: mb/google/dedede/var/madoo: Configure GPIO for Madoo

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: Update...

Dtrain Hsu (Code Review)

23 Jul 2020 23 Jul '20

6:17 a.m.

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f --- A src/mainboard/google/dedede/variants/madoo/Makefile.inc A src/mainboard/google/dedede/variants/madoo/gpio.c 2 files changed, 31 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/1

diff --git a/src/mainboard/google/dedede/variants/madoo/Makefile.inc b/src/mainboard/google/dedede/variants/madoo/Makefile.inc new file mode 100644 index 0000000..eb2c9bc --- /dev/null +++ b/src/mainboard/google/dedede/variants/madoo/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +ramstage-y += gpio.c diff --git a/src/mainboard/google/dedede/variants/madoo/gpio.c b/src/mainboard/google/dedede/variants/madoo/gpio.c new file mode 100644 index 0000000..50a183a --- /dev/null +++ b/src/mainboard/google/dedede/variants/madoo/gpio.c @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> + +/* Pad configuration in ramstage */ +static const struct pad_config override_gpio_table[] = { + /* A13 : USB_OC2_N */ + PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), + /* D12 : WCAM_RST_L */ + PAD_NC(GPP_D12, NONE), + /* D13 : EN_PP2800_CAMERA */ + PAD_NC(GPP_D13, NONE), + /* D14 : EN_PP1200_CAMERA */ + PAD_NC(GPP_D14, NONE), + /* D15 : UCAM_RST_L */ + PAD_NC(GPP_D15, NONE), + /* S2 : DMIC1_CLK */ + PAD_NC(GPP_S2, NONE), + /* S3 : DMIC1_DATA */ + PAD_NC(GPP_S3, NONE), +}; + +const struct pad_config *variant_override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(override_gpio_table); + return override_gpio_table; +} \ No newline at end of file

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

build bot (Jenkins) (Code Review)

23 Jul 23 Jul

6:17 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 11: PAD_NC(GPP_D12, NONE), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 19: PAD_NC(GPP_S2, NONE), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 28: } adding a line without newline at end of file

Dtrain Hsu (Code Review)

6:23 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/2

build bot (Jenkins) (Code Review)

6:23 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/2/src/mainboard/google/dedede... PS2, Line 28: } adding a line without newline at end of file

Dtrain Hsu (Code Review)

6:27 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/3

Karthik Ramasubramanian (Code Review)

24 Jul 24 Jul

9:21 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 17: PAD_NC(GPP_D15, NONE), Is Madoo using USB Camera and not using MIPI Camera?

If not using MIPI Camera, then probably need to mark CLK_24M_UCAM, CLK_24M_WCAM as NC. Also mark the I2C lines to camera as NC i.e. AP_I2C_CAM_SDA, AP_I2C_CAM_SCL as NC.

If using USB Camera is there an enable GPIO for the camera?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 07:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:36 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), What is this USB Overcurrent Pin being used for?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 07:36:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

9:49 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f --- A .vscode/settings.json A src/mainboard/google/dedede/variants/madoo/Makefile.inc A src/mainboard/google/dedede/variants/madoo/gpio.c 3 files changed, 53 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/4

Dtrain Hsu (Code Review)

9:52 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 17: PAD_NC(GPP_D15, NONE),

...

Is Madoo using USB Camera and not using MIPI Camera? […]

Madoo is only using USB Camera and no enable gpio for the camera.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 07:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

9:53 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/5

Dtrain Hsu (Code Review)

9:56 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1),

...

What is this USB Overcurrent Pin being used for?

It just for USB overcurrent.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 07:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

10 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#6).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/6

Dtrain Hsu (Code Review)

10:15 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#7).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/7

Dtrain Hsu (Code Review)

10:35 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#8).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/8

EricR Lai (Code Review)

11:18 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 8: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 8 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Jul 2020 09:18:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

7:16 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 8: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1),

...

It just for USB overcurrent.

All the USB over current events are handled at the EC and not at the AP. So I am not sure if it needs to be routed to AP. I do not want to block this change for this reason. But please do revisit this GPIO later.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 8 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 17:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

7:27 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1),

...

All the USB over current events are handled at the EC and not at the AP. […]

IIUC, this will handled by PCH and send waring to the kernel then shutdown the controller for a while. Does this not work anymore?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 8 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 24 Jul 2020 17:27:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

27 Jul 27 Jul

4:12 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, EricR Lai, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#9).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_A13 - USB_OC_2 GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 9 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Dtrain Hsu (Code Review)

4:15 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:

https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede... PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1),

...

IIUC, this will handled by PCH and send waring to the kernel then shutdown the controller for a whil […]

Follow waddledoo settings. If it needs to be routed to AP, will revisit the GPIO.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 9 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 02:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

4:22 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, EricR Lai, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43745

to look at the new patch set (#10).

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43745/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 10 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

5:29 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 10 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 03:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Jul 28 Jul

9:19 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43745 )

Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................

mb/google/dedede/var/madoo: Configure GPIO for Madoo

Follow schematic to modify some GPIO pins.

GPP_D12 - NC Pin GPP_D13 - NC Pin GPP_D14 - NC Pin GPP_D15 - NC Pin GPP_E0 - NC Pin GPP_E2 - NC Pin GPP_H6 - NC Pin GPP_H7 - NC Pin GPP_S02 - NC Pin GPP_S03 - NC Pin

BUG=b:161407664 BRANCH=NONE TEST=Build the coreboot image on madoo board.

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Reviewed-on: https://review.coreboot.org/c/coreboot/+/43745 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/dedede/variants/madoo/Makefile.inc A src/mainboard/google/dedede/variants/madoo/gpio.c 2 files changed, 37 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/madoo/Makefile.inc b/src/mainboard/google/dedede/variants/madoo/Makefile.inc new file mode 100644 index 0000000..eb2c9bc --- /dev/null +++ b/src/mainboard/google/dedede/variants/madoo/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +ramstage-y += gpio.c diff --git a/src/mainboard/google/dedede/variants/madoo/gpio.c b/src/mainboard/google/dedede/variants/madoo/gpio.c new file mode 100644 index 0000000..f9f8ea2 --- /dev/null +++ b/src/mainboard/google/dedede/variants/madoo/gpio.c @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> + +/* Pad configuration in ramstage */ +static const struct pad_config override_gpio_table[] = { + /* D12 : WCAM_RST_L */ + PAD_NC(GPP_D12, NONE), + /* D13 : EN_PP2800_CAMERA */ + PAD_NC(GPP_D13, NONE), + /* D14 : EN_PP1200_CAMERA */ + PAD_NC(GPP_D14, NONE), + /* D15 : UCAM_RST_L */ + PAD_NC(GPP_D15, NONE), + /* E0 : CLK_24M_UCAM */ + PAD_NC(GPP_E0, NONE), + /* E2 : CLK_24M_WCAM */ + PAD_NC(GPP_E2, NONE), + /* H6 : AP_I2C_CAM_SDA */ + PAD_NC(GPP_H6, NONE), + /* H7 : AP_I2C_CAM_SCL */ + PAD_NC(GPP_H7, NONE), + /* S2 : DMIC1_CLK */ + PAD_NC(GPP_S2, NONE), + /* S3 : DMIC1_DATA */ + PAD_NC(GPP_S3, NONE), +}; + +const struct pad_config *variant_override_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(override_gpio_table); + return override_gpio_table; +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/43745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f Gerrit-Change-Number: 43745 Gerrit-PatchSet: 11 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1562

days inactive

1567

days old

coreboot-gerrit@coreboot.org

21 comments

5 participants

tags (0)

participants (5)

build bot (Jenkins) (Code Review)
Dtrain Hsu (Code Review)
EricR Lai (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)