Attention is currently required from: Alexander Couzens, Felix Singer, Nicholas Chin, Paul Menzel.
Jan Philipp Groß has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151)
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/lenovo/m900/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/74187/comment/fb00b0cf_73687ab9?usp... :
PS3, Line 14:
Nit: drop blank line?
File src/mainboard/lenovo/m900/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/74187/comment/d6ab9fc9_6fe9f96e?usp... :
PS3, Line 16: HDMI3,
What's the output of `xrandr`? According to the images of the board that I've found, it does not feature any HDMI ports?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74187?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22
Gerrit-Change-Number: 74187
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 09 Feb 2025 09:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jan Philipp Groß (Code Review)