Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85841?usp=email )
Change subject: soc/mediatek/mt8196: Add clk_buf drivers ......................................................................
Patch Set 2:
(3 comments)
File src/soc/mediatek/mt8196/clkbuf_ctl.c:
https://review.coreboot.org/c/coreboot/+/85841/comment/23842b00_0195228d?usp... : PS1, Line 419: 124
please define
Done
File src/soc/mediatek/mt8196/include/soc/clkbuf_ctl.h:
https://review.coreboot.org/c/coreboot/+/85841/comment/9d1fc260_17f0e2ad?usp... : PS1, Line 378:
remove the blank line
Done
https://review.coreboot.org/c/coreboot/+/85841/comment/f7fd02f1_4f7f6431?usp... : PS1, Line 379: /* Update PMIF base by platform if needed */ : #if !defined(PMIF_SPMI_P_BASE_CLKBUF) : #define PMIF_SPMI_P_BASE_CLKBUF 0x1C014000 : #endif /* !defined(PMIF_SPMI_P_BASE_CLKBUF) */
You should add PMIF_SPMI_P_CLKBUF_BASE to addressmap. […]
Done