Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50904 )
Change subject: mb/amd/padmelon: Replace `HAVE_S3_SUPPORT` symbol ......................................................................
mb/amd/padmelon: Replace `HAVE_S3_SUPPORT` symbol
Replace it with `HAVE_ACPI_RESUME`, which defaults to n for this board.
Change-Id: Ibb07c0d001ded8d7ff991bf63607872bf4b79c8e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/50904 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/amd/padmelon/Kconfig M src/mainboard/amd/padmelon/gpio.c 2 files changed, 2 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 48df9ca..aedb1b4 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -44,10 +44,6 @@ select AMD_APU_MERLINFALCON if PADMELON_MERLIN_FALCON select AMD_APU_PRAIRIEFALCON if PADMELON_PRAIRIE_FALCON
-config HAVE_S3_SUPPORT - bool - default n - config MAX_CPUS int default 4 diff --git a/src/mainboard/amd/padmelon/gpio.c b/src/mainboard/amd/padmelon/gpio.c index 7897d7b..228da50 100644 --- a/src/mainboard/amd/padmelon/gpio.c +++ b/src/mainboard/amd/padmelon/gpio.c @@ -20,7 +20,7 @@ };
static const struct soc_amd_gpio gpio_set_stage_ram[] = { -#if CONFIG(HAVE_S3_SUPPORT) +#if CONFIG(HAVE_ACPI_RESUME) /* PCIE_WAKE - default, do not program */
/* DEVSLP1 */ @@ -34,7 +34,7 @@
/* WLAND - default as GPIO, do not program */
-#endif /* HAVE_S3_SUPPORT */ +#endif /* HAVE_ACPI_RESUME */ /* BLINK - reselect GPIO OUTPUT HIGH to force BLINK */ PAD_GPO(GPIO_11, HIGH), };