[S] Change in coreboot[main]: Documentation: Fix wrong link to commit message guidelines
Attention is currently required from: Felix Singer, Martin L Roth.
Werner Zeh has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email )
Change subject: Documentation: Fix wrong link to commit message guidelines ......................................................................
Patch Set 1:
(6 comments)
File Documentation/contributing/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/85915/comment/e91b7a4e_881c71e7?usp... : PS1, Line 445: -
Please use asterisks for consistency as it's done for all other places in this document.
Acknowledged
https://review.coreboot.org/c/coreboot/+/85915/comment/f18d6544_83fadb14?usp... : PS1, Line 455: gerrit
Uppercase […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85915/comment/f36f89fe_87ff5906?usp... : PS1, Line 456: signed
Uppercase […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85915/comment/191a2258_beb79b12?usp... : PS1, Line 459: install the commit-msg hook
Since there is no reference, it's a bit confusing how to get this thing. […]
Yes, I stumbled across this, too. We do have Documentation/corebootBuildingGuide.tex where the installation of this hook is kind of described but it seems like .tex-files are not used to render our documentation, right? Still, the easiest way to install the hooks would be ```make gitconfig``` which is not what is described in the .tex-file. That might need an update, too.
On the other hand we could simply add this ```make giconfig``` command here as the instruction on how to install these hooks and let it be.
I will modify the patch to show how it could look like. What do you think?
https://review.coreboot.org/c/coreboot/+/85915/comment/73e8b971_aafe0060?usp... : PS1, Line 460: to
Typo […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85915/comment/6d7080a1_c4d76d72?usp... : PS1, Line 468: she or he
Simplification […]
Acknowledged
-
Werner Zeh (Code Review)