HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45281 )
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL+ Syntax ......................................................................
mb/intel/d945gclf/acpi: Convert platform.asl to ASL+ Syntax
Change-Id: Ic48008719a9cf6942ae8cdaebaab6ba43e665489 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/d945gclf/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45281/1
diff --git a/src/mainboard/intel/d945gclf/acpi/platform.asl b/src/mainboard/intel/d945gclf/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/intel/d945gclf/acpi/platform.asl +++ b/src/mainboard/intel/d945gclf/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45281
to look at the new patch set (#2).
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL+ Syntax ......................................................................
mb/intel/d945gclf/acpi: Convert platform.asl to ASL+ Syntax
It builds same binary for intel/d945gclf using BUILD_TIMELESS=1
Change-Id: Ic48008719a9cf6942ae8cdaebaab6ba43e665489 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/d945gclf/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45281/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45281
to look at the new patch set (#3).
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax
It builds same binary for intel/d945gclf using BUILD_TIMELESS=1
Change-Id: Ic48008719a9cf6942ae8cdaebaab6ba43e665489 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/d945gclf/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45281/3
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45281 )
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45281 )
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax
It builds same binary for intel/d945gclf using BUILD_TIMELESS=1
Change-Id: Ic48008719a9cf6942ae8cdaebaab6ba43e665489 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45281 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/d945gclf/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/intel/d945gclf/acpi/platform.asl b/src/mainboard/intel/d945gclf/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/intel/d945gclf/acpi/platform.asl +++ b/src/mainboard/intel/d945gclf/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45281 )
Change subject: mb/intel/d945gclf/acpi: Convert platform.asl to ASL 2.0 syntax ......................................................................
Patch Set 4: Code-Review+2
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)
-
Tim Wawrzynczak (Code Review)