Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document
......................................................................
Patch Set 4: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_...
File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md:
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_...
PS4, Line 86: charging applet onto screen.
That is against coreboot’s principles.
@Paul, can you please help to understand why its against coreboot principal ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0d70d81890a60212c914b6bc2bfc7e35479ba9
Gerrit-Change-Number: 37762
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 18 Mar 2020 19:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment