Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35599 )
Change subject: arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK ......................................................................
arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK
Change-Id: I294a3fd7be57b505cd209f7c2718a05770786c51 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/mips/include/arch/header.ld M src/arch/ppc64/include/arch/header.ld 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/35599/1
diff --git a/src/arch/mips/include/arch/header.ld b/src/arch/mips/include/arch/header.ld index 6650132..7f832eb 100644 --- a/src/arch/mips/include/arch/header.ld +++ b/src/arch/mips/include/arch/header.ld @@ -19,7 +19,7 @@ to_load PT_LOAD; }
-#ifdef __BOOTBLOCK__ +#if ENV_BOOTBLOCK ENTRY(_start) #else ENTRY(stage_entry) diff --git a/src/arch/ppc64/include/arch/header.ld b/src/arch/ppc64/include/arch/header.ld index 349fd51..badeefd 100644 --- a/src/arch/ppc64/include/arch/header.ld +++ b/src/arch/ppc64/include/arch/header.ld @@ -19,7 +19,7 @@ to_load PT_LOAD; }
-#ifdef __BOOTBLOCK__ +#if ENV_BOOTBLOCK ENTRY(_start) #else ENTRY(stage_entry)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35599 )
Change subject: arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35599 )
Change subject: arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35599 )
Change subject: arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK ......................................................................
arch/: Replace __BOOTBLOCK__ with ENV_BOOTBLOCK
Change-Id: I294a3fd7be57b505cd209f7c2718a05770786c51 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35599 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/arch/mips/include/arch/header.ld M src/arch/ppc64/include/arch/header.ld 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/arch/mips/include/arch/header.ld b/src/arch/mips/include/arch/header.ld index 6650132..7f832eb 100644 --- a/src/arch/mips/include/arch/header.ld +++ b/src/arch/mips/include/arch/header.ld @@ -19,7 +19,7 @@ to_load PT_LOAD; }
-#ifdef __BOOTBLOCK__ +#if ENV_BOOTBLOCK ENTRY(_start) #else ENTRY(stage_entry) diff --git a/src/arch/ppc64/include/arch/header.ld b/src/arch/ppc64/include/arch/header.ld index 349fd51..badeefd 100644 --- a/src/arch/ppc64/include/arch/header.ld +++ b/src/arch/ppc64/include/arch/header.ld @@ -19,7 +19,7 @@ to_load PT_LOAD; }
-#ifdef __BOOTBLOCK__ +#if ENV_BOOTBLOCK ENTRY(_start) #else ENTRY(stage_entry)
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)