Attention is currently required from: Paul Menzel. Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56417 )
Change subject: mb/google/dedede/var/cappy2: Adding I2C devices support in devicetree and associated GPIO configuration ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56417/comment/3f3518c8_ff63e775 PS1, Line 2: Sunway
Is that your full name?
Yes,it is~
https://review.coreboot.org/c/coreboot/+/56417/comment/cbeb9cae_5d08ec7f PS1, Line 7: Adding
Imperative mood [1]: Add […]
I have changed it
https://review.coreboot.org/c/coreboot/+/56417/comment/765f3694_03d8818c PS1, Line 10: Adding I2C devices and tpm support in devicetree and associated GPIO configuration.
Please seperate the TPM change out into its own commit.
I have changed it as ur advice
File src/mainboard/google/dedede/variants/cappy2/gpio.c:
https://review.coreboot.org/c/coreboot/+/56417/comment/ad83ff4d_af3c97f3 PS1, Line 8: WWAN_SAR_DETECT_ODL*/
Missing space.
Done